Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offer-uuid to look up offer permissions and send messages between models #7734

Merged
merged 1 commit into from Aug 11, 2017

Conversation

wallyworld
Copy link
Member

Description of change

Use the UUID of the offer instead of the name to:

  • communicate between models
  • add as a first party caveat to macaroons
  • look up access permission

QA steps

Run up a cmr scenario
Ensure relation works
Add user, grant permission
Ensure added user can relate to the offer

@wallyworld wallyworld force-pushed the cmr-use-offer-uuid branch 2 times, most recently from 33b9f53 to d4941b7 Compare August 11, 2017 06:02
// OfferName is the name of the application offer from the local model.
OfferName string `json:"offer-name"`
// OfferUUID is the UUID of the offer.
OfferUUID string `json:"offer-name"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/name/uuid/

@wallyworld
Copy link
Member Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Aug 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Aug 11, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/118

@wallyworld
Copy link
Member Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Aug 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 3d60d54 into juju:develop Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants