Use offer-uuid to look up offer permissions and send messages between models #7734

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
3 participants
Owner

wallyworld commented Aug 11, 2017

Description of change

Use the UUID of the offer instead of the name to:

  • communicate between models
  • add as a first party caveat to macaroons
  • look up access permission

QA steps

Run up a cmr scenario
Ensure relation works
Add user, grant permission
Ensure added user can relate to the offer

axw approved these changes Aug 11, 2017

apiserver/params/crossmodel.go
- // OfferName is the name of the application offer from the local model.
- OfferName string `json:"offer-name"`
+ // OfferUUID is the UUID of the offer.
+ OfferUUID string `json:"offer-name"`
@axw

axw Aug 11, 2017

Member

s/name/uuid/

Owner

wallyworld commented Aug 11, 2017

$$merge$$

Contributor

jujubot commented Aug 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

Contributor

jujubot commented Aug 11, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/118

Owner

wallyworld commented Aug 11, 2017

$$merge$$

Contributor

jujubot commented Aug 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 3d60d54 into juju:develop Aug 11, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment