propagate host's AZ to containers #7796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!!build!! |
2 similar comments
|
!!build!! |
|
!!build!! |
added 3 commits
August 31, 2017 14:46
pad.lv/1684325 Currently a provider-specific AZ is not propagated to containers deployed on any provider - during container creation an empty HardwareCharacteristics struct is initialized by a container manager. It is important for certain applications to have this value exposed as an environment variable in the hook context so that they can be configured to be aware of physical placement with respect to failure domains. Given that provisioner has an ability to query machine state via an apiserver facade, it is possible to get an availability zone for a machine with a given tag. For that a new API call is introduced to query that information.
agent and apiserver side tests + a test for availability zone retrieval and a container AZ test
Given that there is an additional step to retrieve host hardware characteristics we error out earlier than before and do not receive the same error message. For this reason the expected result was changed and the test was renamed.
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
pad.lv/1684325
Currently a provider-specific AZ is not propagated to containers
deployed on any provider - during container creation an empty
HardwareCharacteristics struct is initialized by a container manager.
It is important for certain applications to have this value exposed as
an environment variable in a hook context so that they can be
configured to be aware of physical placement with respect to failure
domains.
Given that provisioner has an ability to query machine state via
an apiserver facade, it is possible to get an availability zone for a
machine with a given tag. For that a new API call is introduced to query
that information.
QA steps
http://paste.ubuntu.com/25411702/
Documentation changes
Creates a new facade call AvailabilityZone which allows to query that field from hardware characteristics stored in state for a machine identified by a given tag.
Bug reference
https://bugs.launchpad.net/juju/+bug/1684325
https://bugs.launchpad.net/charm-ceph-osd/+bug/1684330