Model "not found" handled consistently. #7797
Conversation
cmd/juju/model/dump.go
Outdated
| @@ -101,6 +101,13 @@ func (c *dumpCommand) Run(ctx *cmd.Context) error { | |||
| } | |||
|
|
|||
| modelDetails, err := store.ModelByName(controllerName, c.model) | |||
There was a problem hiding this comment.
can you please instead add a new method to ControllerCommandBase?
func (*ControllerCommandBase) ModelDetails(modelName string) (*jujuclient.ModelDetails, error)which will do the refresh, just like ModelCommandBase.ModelDetails
There was a problem hiding this comment.
I am not sure if it's worth it.
It looks like these 2 are the only commands that will call it and I agree with Roger that they both should be model-type commands anyway. I might just change them to be :) This will eliminate code duplication and couple of todos :D
There was a problem hiding this comment.
I concur. Please notify the mailing lists after it's done.
|
Changed "dump" and "dump-db" to be model-type commands. |
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Description of change
There are places in CLI where 'model not found" could benefit from models refresh on client side.
This PR identified all these places and corrected them to use consistent approach.
QA steps
n/a - internal change.
Documentation changes
n/a - internal change
Bug reference
n/a