2.2 pingbatcher 1720155 #7900
Merged
2.2 pingbatcher 1720155 #7900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing Upsert, it doesn't return an error, but it does say that no documents were modified.
Mongo 2.4 appears to have a bug wrt Upsert and $bit operations. See bug #1720155 and #1699678 for more details. This does a Database version check and uses appropriate operations.
jameinel
force-pushed
the
2.2-pingbatcher-1720155
branch
from
9fa110e
to
d3b8ff4
Compare
|
We'd planned on getting 2.6 into trusty, but it never happened. It seems we should consider restoring running on mongo2.4 and trusty, or restart the effort to move to mongo 2.6 |
wallyworld
approved these changes
Oct 4, 2017
state/presence/pingbatcher.go
Outdated
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| // if changeInfo.Updated == 0 { |
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
It turns out that $bit operations do not work well with Upsert and Mongo 2.4. I had written the original patch against Mongo 2.6 which is why I thought everything worked, but it seems that things break if you use the 2.4 that we have on Trusty.
QA steps
The existing test suite would fail if run against Mongo 2.4 which should have caught this, but apparently were weren't actually running there? An easy way to test this is to grab a trusty VM/LXD container, and then 'apt install juju-mongodb' and run the test suite in state/presence.
Documentation changes
None
Bug reference
lp:1720155