Fix for BUG 1689683 #7905
Merged
Fix for BUG 1689683 #7905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no external-network specified, pick one from same AZ as the instance network. If external-network specified, use that.
|
Can one of the admins verify this patch? |
wallyworld
approved these changes
Oct 4, 2017
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Merged
jujubot
added a commit
that referenced
this pull request
Oct 19, 2017
Back port of PR7905 If no external-network specified, pick one from same AZ as the instance network. If external-network specified, use that. #7905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
If a user specifies an external-network, use the specified network for floating-ips, if it exists
without checking availability zones.
If no external-network is specified, pick one from same availability zone as the network
specified for the instance we're finding an floating-ip for.
QA steps
Bootstrap an OpenStack cloud where network availability zones have been configured and has an external network. --config use-floating-ip=true should be specified.
Documentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1689683