Rephrase error message when agent versions != client version. #7911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
reviewed
Oct 5, 2017
cmd/juju/commands/bootstrap.go
Outdated
| @@ -236,7 +236,7 @@ func (c *bootstrapCommand) Init(args []string) (err error) { | |||
| } | |||
| } | |||
| if c.AgentVersion != nil && (c.AgentVersion.Major != jujuversion.Current.Major || c.AgentVersion.Minor != jujuversion.Current.Minor) { | |||
| return errors.New("requested agent version major.minor mismatch") | |||
| return errors.Errorf("this client can only bootstrap %v.%v+ agents", jujuversion.Current.Major, jujuversion.Current.Minor) | |||
There was a problem hiding this comment.
Just a thought
2.3+ could imply anything greater than 2.3, eg 2.4
How about
2.3.x
There was a problem hiding this comment.
Yes, I thought of that but then about about beta versions and such? they take form of, say 2.3-b3...
Maybe just drop suffix altogether? so "...can only bootstrap 2.3 agents"?
wallyworld
approved these changes
Oct 5, 2017
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When bootstrapping controllers with agent version that is different from client version, we'd get a fairly obscure message:
$ juju bootstrap aws mycontroller --agent-version=2.2.3
ERROR requested agent version major.minor mismatch
To avoid surprises and headaches, this PR proposes to re-phrase this message in a user-friendly way:
$ juju bootstrap aws mycontroller --agent-version=2.2.3
ERROR this client can only bootstrap 2.3 agents
QA steps
As per description above.
Documentation changes
n/a
Bug reference
n/a