Ignore not found models on destroy and backup. #7956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
approved these changes
Oct 24, 2017
state/backups/backups_linux.go
Outdated
| @@ -277,6 +277,10 @@ func (b *backups) Restore(backupId string, dbInfo *DBInfo, args RestoreArgs) (na | |||
| for _, modelUUID := range modelUUIDs { | |||
| st, release, err := pool.Get(modelUUID) | |||
| if err != nil { | |||
| // This model could have been removed. | |||
There was a problem hiding this comment.
we're restoring, so they shouldn't have been removed?
|
Removed the change in restore to avoid controversy. Let's wait until we see the need for it. |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There are several circumtances under which behavior described in the linked bug can occur. Specifically, anywhere where we have a list of models but any model can be destroyed while we are iterating over the list.
We have addressed the actual listing of models. This PR addresses model destruction and backup.
Bug reference
https://bugs.launchpad.net/juju/+bug/1721786