Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for bug 1707248 #7983

Merged
merged 1 commit into from Oct 29, 2017
Merged

fix for bug 1707248 #7983

merged 1 commit into from Oct 29, 2017

Conversation

hmlanigan
Copy link
Member

Description of change

avoid panic by adding distributionGroupFinder to containerProvisioner.

QA steps

  1. juju bootstrap localhost
  2. juju deploy mysql -n 2 --to lxd,lxd
  3. ensure that 0/lxd/0 and 1/lxd/0 are provisioned.

Documentation changes

N/A

Bug reference

https://bugs.launchpad.net/juju/+bug/1728066

@jujubot
Copy link
Collaborator

jujubot commented Oct 28, 2017

Can one of the admins verify this patch?

Copy link
Member

@jameinel jameinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems ok, but why didn't the test suite catch it? Is it a case that it would have been caught in the CI tests, but you actually need to provision a container?

@hmlanigan
Copy link
Member Author

$$merge$$

@hmlanigan
Copy link
Member Author

hmlanigan commented Oct 29, 2017

It fell in the cracks with test cases in the test suite. The container brokers test that StartInstance() works within out the instance starting. The container_initializer tests called the provisioner correctly, but containers are never actually provisioned. CI tests don't provision containers. Yes, you'd need provision a container within a juju machine to hit this.

@jujubot
Copy link
Collaborator

jujubot commented Oct 29, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 1f51957 into juju:develop Oct 29, 2017
@hmlanigan hmlanigan deleted the bug1728066 branch August 31, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants