[1.25] state: restart leadership worker if it fails #8046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run the leadership manager in a worker.Runner, restarting it if it fails. The methods on State for returning leadership claimers and checkers defer obtaining the current worker until the claim/check methods are invoked, to avoid pinning to broken workers.
wallyworld
approved these changes
Nov 10, 2017
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jameinel
reviewed
Nov 10, 2017
| @@ -177,6 +178,9 @@ func (client *client) ExpireLease(name string) error { | |||
| // Refresh is part of the Client interface. | |||
| func (client *client) Refresh() error { | |||
| client.logger.Tracef("refreshing") | |||
| if wrench.IsActive("lease", "refresh") { | |||
There was a problem hiding this comment.
This leads to a lot of DEBUG level complaints about wrench directory not existing.
Is it worth the effort to add it?
There was a problem hiding this comment.
Worth the effort to add what? We can remove it, but it seems to me the right thing to do is change wrench to use the TRACE level.
There was a problem hiding this comment.
I agree with @axw on that point.
There was a problem hiding this comment.
@axw care to do a simple follow up branch that moves the wrench package Debug statements to Trace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Run the leadership manager in a worker.Runner,
restarting it if it fails. The methods on State
for returning leadership claimers and checkers
defer obtaining the current worker until the
claim/check methods are invoked, to avoid
pinning to broken workers.
QA steps
(wait)
(observe leadership manager failures in log)
(observe some time later that the leadership manager is restarted)
Documentation changes
None.
Bug reference
https://bugs.launchpad.net/juju-core/+bug/1729930