Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix upgrade-juju --dry-run and upgrades from custom binaries #8102
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
!!build!! |
jujubot
merged commit 6f19643
into
juju:develop
Nov 17, 2017
1 check was pending
continuous-integration/jenkins/pr-merge
This commit is being built
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedNov 17, 2017
Description of change
There were several small issues with upgrade-juju. The main one occurred when running a custom build (with a build number > 0). --dry-run would report n upgrade available, but then running the upgrade would not use the available version and instead upload a new custom build.
Other fixes include some message tweaks and not actually building a local jujud when using dry run.
QA steps
Run up a custom build, eg 2.3-beta2.1
Use juju upgrade-juju with no args and ensure it upgrades to 2.3-beta3
(it would fail before)
Documentation changes
None, just fixing bad behaviour.
Bug reference
https://bugs.launchpad.net/juju/+bug/1732879