Fix upgrade-juju --dry-run and upgrades from custom binaries #8102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
force-pushed
the
upgrade-juju-fixes
branch
from
da7a6ec
to
dba98ab
Compare
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
wupeka
approved these changes
Nov 17, 2017
|
!!build!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
There were several small issues with upgrade-juju. The main one occurred when running a custom build (with a build number > 0). --dry-run would report n upgrade available, but then running the upgrade would not use the available version and instead upload a new custom build.
Other fixes include some message tweaks and not actually building a local jujud when using dry run.
QA steps
Run up a custom build, eg 2.3-beta2.1
Use juju upgrade-juju with no args and ensure it upgrades to 2.3-beta3
(it would fail before)
Documentation changes
None, just fixing bad behaviour.
Bug reference
https://bugs.launchpad.net/juju/+bug/1732879