worker/caasoperator: download & unpack charm #8151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use lumberjack in the CAAS operator; output logs to stderr, so CAAS native log facilities can be used (e.g. kubectl logs). Also, move Dockerfile under the caas directory.
wallyworld
approved these changes
Nov 29, 2017
| // ForceUpgrade indicates whether or not application | ||
| // units should upgrade to the charm even if they | ||
| // are in an error state. | ||
| ForceUpgrade bool `json:"force-upgrade,omitempty"` |
There was a problem hiding this comment.
Do we need this? We don't upgrade running units.
There was a problem hiding this comment.
I'm thinking we might want to use this type for the uniter, to avoid making two calls like we do now (one to get the charm URL/force flag, another to get the SHA256 sum).
When the operator starts up, it checks if it has a charm directory. If it does not, it will ask for the application's charm URL and SHA256 hash, download and verify, and then unpack it into the charm directory. The agent also sets its status to maintenance during that process, and active later.
axw
force-pushed
the
caas-operator-fetch-charm
branch
from
95bd3ac
to
53c0e65
Compare
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When the operator starts up, it checks if it
has a charm directory. If it does not, it will
ask for the application's charm URL and SHA256
hash, download and verify, and then unpack it
into the charm directory. The agent also sets
its status to maintenance during that process,
and active later.
Also:
kubectl logs)QA steps
(wait for pod to be recreated)
(should see via logs that the charm is downloaded and "ready at /var/lib/juju/charm")
(should see contents of ubuntu charm)
Documentation changes
None.
Bug reference
None.