Fix add-credential help documentation. #8161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
!!build!! |
|
We should never require the user specify "/dev/stdin". If we want to do something like that, we should support using "-" to mean stdin. |
|
Is this PR good for approval? |
|
I would defer to Andrew who did the actual changes to how we initialize
Azure. I know at one point we had a rather difficult set of steps because
Azure wanted us to create groups, etc. It seems we probably automated most
of that inside Juju, but I wouldn't be able to tell if the new config was
correct without direct tests and I'm away from my machines right now.
It looks reasonable, but I can't confirm it's correctnes here.
John
=:->
…On Dec 1, 2017 14:08, "Eric" ***@***.***> wrote:
Is this PR good for approval?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#8161 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAMYfRp6-jCFBWvqxBI47rxq1IIo5YYTks5s79AFgaJpZM4QxOdT>
.
|
|
OK, will defer @axw |
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
juju add-credentailhelp documentation is incorrect.QA steps
Feeding the help message's example credential file to an
add-credentialcommand that use it should work:Then edit
example_creds.yamlwith valid azure credentialsThen you should be able to bootstrap a controller on azure. Notice how before this patch bootstrapping using this method would fail since
tenant_idis not recognized by juju's credential validation and adding it to the file would result in the following error when bootstrapping:Documentation changes
The online documentation is also incorrect. A PR is has been opened with the relevant fix.
Bug reference
https://bugs.launchpad.net/juju/+bug/1690920