Add uniter API upward compatibility for "NetworkInfo" endpoint. #8235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ExternalReality
changed the title
ExternalReality
force-pushed
the
bug#1737058
branch
from
8fcf6c8
to
0b0e557
Compare
ExternalReality
force-pushed
the
bug#1737058
branch
from
0b0e557
to
0ff2bcd
Compare
wupeka
approved these changes
Dec 18, 2017
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
ExternalReality
pushed a commit
to ExternalReality/juju
that referenced
this pull request
Mar 16, 2018
Add uniter API upward compatibility for "NetworkInfo" endpoint. ## Description of change 2.2.x agents are not upward compatible with 2.3.x api servers with respect to the uniter API's `NetworkInfo` endpoint. ## QA steps 1. Bootstrap a 2.2.x controller 2. Deploy a charm with network bindings 3. Upgrade the controller's model to 2.3.x 4. `juju run` a `network-get` action on one of the deployed units to inspect the binding 5. `network-get` should successfully find the binding. ## Documentation changes N/A ## Bug reference https://bugs.launchpad.net/juju/+bug/1737058
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
2.2.x agents are not upward compatible with 2.3.x api servers with respect to the uniter API's
NetworkInfoendpoint.QA steps
juju runanetwork-getaction on one of the deployed units to inspect the bindingnetwork-getshould successfully find the binding.Documentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1737058