Fix non-finalizing update-credential command. #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ExternalReality
force-pushed
the
develop
branch
from
0581394
to
0e6b94a
Compare
ExternalReality
force-pushed
the
develop
branch
from
0e6b94a
to
4b0a6d7
Compare
jameinel
approved these changes
Dec 21, 2017
There was a problem hiding this comment.
I think we need to come back and think about the interface for ClientStore().CredentialForCloud() because that seems to be the obvious place to get credentials, but it doesn't give correct credentials.
One option is to just name it GetRawCredential, or something to make it more obvious that you need to do more than just this.
ExternalReality
force-pushed
the
develop
branch
from
4b0a6d7
to
06f1562
Compare
ExternalReality
force-pushed
the
develop
branch
from
06f1562
to
a77bde0
Compare
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The
juju update-credentialcommand does not process credentials in the same way as other commands. The difference leaves file paths in place in user's YAML credentials file when updating credentials for JSON file based cloud credentials.QA steps
juju upgrade-juju --dry-run- everything should work finejuju update-credentialDocumentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1738991