Only have one top level $addToSet #8259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
approved these changes
Jan 5, 2018
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
This sounds like we should be changing the deserialization code to use a bson.D instead of a bson.M else this will happen elsewhere |
jujubot
added a commit
that referenced
this pull request
Jan 5, 2018
state: combine $addToSet updates for storage ## Description of change When adding filesystems and volumes to a machine document, ensure that only one $addToSet is used. Otherwise, if the transaction is interrupted, its updates will be encoded/decoded as a map, and only one of the $addToSets will be preserved. See also #8259 ## QA steps None - can't force this one. ## Documentation changes None. ## Bug reference None, preemptive strike.
|
It isn't the deserialization, but the serialization of a bson.D. See gopkg.in/mgo.v2/bson/encode.go line 219. It writes the bson.D out as a flattened dict. Changing this serialization is probably not feasible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solutions QA were hitting a situation where regularly their enable-ha command wouldn't result in a mongo replicaset being set up.
Debugging lead to the observation that the controller document had
"machineids": ["0"],
and
"votingmachineids":["0", "1", "2"]
The code always expects that "machineids" is a superset of "votingmachineids".
The transaction ops that were created specified the "$addToSet" mongo operator as a key for two different bson.D values. When this transaction is stashed and recovered, this is flattened to a bson.M that just has a single value.
QA steps
You get a replica-set enabled juju.
Bug reference
https://bugs.launchpad.net/juju/+bug/1720251