Budget command supports moving budgets between wallets. #8262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
approved these changes
Jan 5, 2018
mattyw
approved these changes
Jan 8, 2018
|
Can you have a look at the acceptance test for budgets and add in this new functionality? Or are you happy with unit tests? https://github.com/juju/juju/blob/develop/acceptancetests/assess_budget.py |
cmars
approved these changes
Jan 10, 2018
|
:build: |
|
!!build!! |
|
@howbazaar - @anastasiamac suggested I should get your review on this |
|
@howbazaar, |
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jan 16, 2018
…ving-wallets Budget command supports moving budgets between wallets. This is a forward of #8262 ## Description of change This change enables users to use the `juju budget` command to move a budget to a different wallet (as well as update the budget's limit). This change was requested by beta users. ## QA steps Running the `juju budget` command with a parameter referencing an existing wallet should move the budget to the new wallet. ## Documentation changes The change augments the `juju budget` command.
|
Let the Docs team (me) know if something needs changing at the online documentation level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change enables users to use the
juju budgetcommand to move a budget to a different wallet (as well as update the budget's limit).This change was requested by beta users.
QA steps
Running the
juju budgetcommand with a parameter referencing an existing wallet should move the budget to the new wallet.Documentation changes
The change augments the
juju budgetcommand.