Fix lp:1748275 #8379
Merged
Fix lp:1748275 #8379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babbageclunk
approved these changes
Feb 14, 2018
apiserver/apiserver.go
Outdated
| statePool *state.StatePool | ||
| lis net.Listener | ||
|
|
||
| // tag of the machine where the API server is running. |
There was a problem hiding this comment.
Should have a capital letter! ;)
state/addmachine.go
Outdated
| @@ -824,7 +824,7 @@ func (st *State) maintainControllersOps(mdocs []*machineDoc, currentInfo *Contro | |||
| // according to the specified placement directives until the placement list is | |||
| // exhausted; thereafter any new machines are started according to the constraints and series. | |||
| func (st *State) EnableHA( | |||
| numControllers int, cons constraints.Value, series string, placement []string, | |||
| numControllers int, cons constraints.Value, series string, placement []string, machineId string, | |||
There was a problem hiding this comment.
Could you add a description of what machineId does to the docstring?
hmlanigan
force-pushed
the
bug1748275
branch
2 times, most recently
from
f5bd54e
to
8ae77ab
Compare
simply because the agent pinger isn't alive on the server yet.
hmlanigan
force-pushed
the
bug1748275
branch
from
8ae77ab
to
9332cad
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
If you run juju enable-ha very quickly, e.g. via script, after bootstrap has completed, there is a window of time where the controller hasn't sent a ping yet to agent presence. In this case, it's possible that
EnableHA will demote the server it's running on as part of the enablement process, causing another server to be provisioned.
How do we verify that the change works?
Best bet is to find a cloud this is easily reproducible on to run. It can be difficult to reproduce.
$ juju bootstrap localhost test ; juju enable-ha -c test
Documentation changes
n/a
Bug reference
https://bugs.launchpad.net/juju/+bug/1748275