Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for caas namespaces #8441

Merged
merged 1 commit into from Mar 2, 2018
Merged

Conversation

wallyworld
Copy link
Member

Description of change

Each CAAS model's k8s resources (pods, services, etc) are now created in a namespace named after the model. Because we don't have a model manager worker yet to react to model add/remove, we create and delete the namespace inside the k8s client when an operator is created/deleted. This is a workaround until the necessary model worker can be written.

To provide the model name to the k8s broker tracker, we implement an existing TODO which is to add a bespoke caas agent facade. There's also a driveby fix to clean up the caas operator provisioner worker logic a bit.

QA steps

Run up a CAAS model and check that gitlab/mysql can be deployed and related, and that the expected namespace is used. Delete all model applications and check that the namespace is removed.

Copy link
Contributor

@babbageclunk babbageclunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok.
(It seems crazy to me that there isn't already some way for a worker to get this information - or that it takes so many lines of code + tests to expose the model name to a worker.)

@wallyworld
Copy link
Member Author

$$merge$$

1 similar comment
@wallyworld
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 212ad90 into juju:develop Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants