run config-change hook when caas pod address changes #8514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anastasiamac
approved these changes
Mar 21, 2018
state/watcher.go
Outdated
|
|
||
| var _ Watcher = (*containerAddressesWatcher)(nil) | ||
|
|
||
| // WatchContainerAddresses returns a new NotifyWatcher watching u's pod address(es). |
There was a problem hiding this comment.
I'd rather see "unit's' here than "u's" being a comment and all ... :D
wallyworld
force-pushed
the
caas-address-watcher
branch
from
2865666
to
e6c60fa
Compare
wallyworld
force-pushed
the
caas-address-watcher
branch
from
e6c60fa
to
cab926e
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
When a caas pod address changes, we run the config-change hook for the unit.
Add a new container address watcher based on the existing machine address watcher and its tests.
Also, there's now no longer a need in the uniter remote state to only use address watcher with IAAS models.
Also do a drive by fix for CAAS meterstatus which was unable to be tested live previously due to an upstream k8s bug.
QA steps
deploy a caas charm
stop a pod and let it restart
check the config-changed hook is run