Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes lp#1762600: mark an option as deprecated. #8575

Merged
merged 2 commits into from Apr 11, 2018
Merged

Fixes lp#1762600: mark an option as deprecated. #8575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96251b
Fix the mesage on deprecated, ineffectual option.
anastasiamac Apr 11, 2018
0d0ffb9
Added a descriptive (helpful?) TODO
anastasiamac Apr 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/juju/status/history.go
View file
Open in desktop
Expand Up @@ -99,7 +99,9 @@ func (c *statusHistoryCommand) SetFlags(f *gnuflag.FlagSet) {
f.IntVar(&c.backlogSizeDays, "days", 0, "Returns the logs for the past <days> days (cannot be combined with -n or --date)")
f.StringVar(&c.backlogDate, "from-date", "", "Returns logs for any date after the passed one, the expected date format is YYYY-MM-DD (cannot be combined with -n or --days)")
f.BoolVar(&c.isoTime, "utc", false, "Display time as UTC in RFC3339 format")
f.BoolVar(&c.includeStatusUpdates, "include-status-updates", false, "Inlcude update status hook messages in the returned logs")
// TODO (anastasiamac 2018-04-11) Remove at the next major release, say Juju 2.5+ or Juju 3.x.
// the functionality is no longer there since a fix for lp#1530840
f.BoolVar(&c.includeStatusUpdates, "include-status-updates", false, "Deprecated, has no effect for 2.3+ controllers: Include update status hook messages in the returned logs")
}

func (c *statusHistoryCommand) Init(args []string) error {
Expand Down