Action set #858
Merged
Action set #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
action-set permits action hooks to define an arbitrary map of params which will be returned to the state server at the end of the Action.
Addressed fwereade's concerns for PR 415.
This commit moves the Action results update method into the Context implementation, so that client code is not changing the results map on its own.
Addressed: - need to keep Action results map segregated from jujuc - testing Context interface mock to support this change - removed old Context methods - changed actionResults inner "error" type to string rather than error
action-set now has a test in worker/uniter/uniter. This test demonstrates how action-set overwrites existing values in the results map.
This commit revises action-set behavior to interact correctly with new ActionFinish logic on worker uniter.
This commit wraps up the changes to `action-set` now that ActionFinish has landed in core.
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Build failed: Generating tarball failed |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Sep 29, 2014
Action set action-set permits action hooks to define an arbitrary map of params which will be returned to the state server at the end of the Action. This is a reopen of #415. 415 failed to land due to too many pages of comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
action-set permits action hooks to define an arbitrary map of params
which will be returned to the state server at the end of the Action.
This is a reopen of #415. 415 failed to
land due to too many pages of comments.