Better tests for credential validator worker. #8594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Apr 16, 2018
| worker, err := testWorker(s.config) | ||
| c.Assert(err, jc.ErrorIsNil) | ||
|
|
||
| s.sendChange(c) |
There was a problem hiding this comment.
Is the first change needed? This should still pass with exists=false followed by sendChange()?
Same comment for other test cases below.
|
So according to the testing, I had to add that additional change tot he watched channel as .Add(ing) watcher to the catacomb in a Work method (here, the loop()) consumed a change. To avoid this additional gobbling up, the watcher need to be added to the catacomb before the Plan.Work method, i.e. using Plan.Init in the worker constructor. Doing so did not consume an additional change. However, it did tie the watcher to the lifecycle of the worker and destroyed it when the worker was destroyed. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Based on review comments in PR #8586, this PR improves credential validator worker tests:
QA steps
Internal change so all unit tests are expected to pass.