Explanation for plan.init vs inside plan.work method. #8614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Apr 17, 2018
worker/credentialvalidator/worker.go
Outdated
| @@ -81,6 +81,15 @@ func NewWorker(config Config) (worker.Worker, error) { | |||
| err = catacomb.Invoke(catacomb.Plan{ | |||
| Site: &v.catacomb, | |||
| Work: v.loop, | |||
| // The watcher needs to be added to the worker's catacomb plan | |||
| // here in order to be controlled by this worker lifecycle events: | |||
|
|
anastasiamac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Timing is everything, especially for initialization.
Credential validator worker has a watcher that needs to be initialized before worker's Work.
This PR adds a comment that explains why it needs to happen before Work is started.