Status machine filter tests. #8724
Conversation
featuretests/cmd_juju_status_test.go
Outdated
| func (s *StatusSuite) SetUpTest(c *gc.C) { | ||
| s.JujuConnSuite.SetUpTest(c) | ||
|
|
||
| func (s *StatusSuite) assertMultipleRelationsBetweenApplications(c *gc.C) { |
There was a problem hiding this comment.
Maybe setupMultipleRelationsBetweenApplications
assertFoo() is typically used to test the results of doing something after it has happened and we want to check that the code behaved as expected.
Here, we are setting up a scenario for which we then want to run a test
featuretests/cmd_juju_status_test.go
Outdated
| @@ -68,6 +67,7 @@ func (s *StatusSuite) run(c *gc.C, args ...string) *cmd.Context { | |||
| } | |||
|
|
|||
| func (s *StatusSuite) TestMultipleRelationsInYamlFormat(c *gc.C) { | |||
| s.assertMultipleRelationsBetweenApplications(c) | |||
There was a problem hiding this comment.
As per above comment, this would be clearer as s.setupMultipleRelations.....
featuretests/cmd_juju_status_test.go
Outdated
| context := s.run(c, "status", "--relations") | ||
| c.Assert(cmdtesting.Stdout(context), jc.Contains, ` | ||
| Relation provider Requirer Interface Type Message | ||
| wordpress:juju-info logging:info juju-info subordinate joining | ||
| wordpress:logging-dir logging:logging-directory logging subordinate joining | ||
| `[1:]) | ||
| } | ||
|
|
||
| func (s *StatusSuite) assertServeralUnitsOnAMachines(c *gc.C) { |
featuretests/cmd_juju_status_test.go
Outdated
| func (s *StatusSuite) TestStatusWhenFilteringByMachine(c *gc.C) { | ||
| s.assertServeralUnitsOnAMachines(c) | ||
|
|
||
| // Put a unit from the application C on a different machine. |
There was a problem hiding this comment.
I didn't know what application C was until a dig in a bit. Maybe reword the comment just to say we are adding a new application to a machine ti ensure it is filtered out as expected.
featuretests/cmd_juju_status_test.go
Outdated
| Application: application, | ||
| Machine: machine10, | ||
| }) | ||
| context := s.run(c, "status", "1") |
There was a problem hiding this comment.
Just to ensure and check there really is a machine 10, can we also run an check that "status 10" works as expected. Otherwise the test could pass by mistake.
|
|
#8737 ## Description of change Merge 2.3 into develop, including the Mongo changes and resolving any small issue with the double ported status changes. This includes these new patches: prdesc Merge pull request #8718 from jameinel/2.3-mongodb-version And these patches that were independently directly merged into develop: prdesc Merge pull request #8727 from anastasiamac/empty-status-friendly-msg prdesc Merge pull request #8724 from anastasiamac/status-machine-filter-tests-23 prdesc Merge pull request #8717 from anastasiamac/multi-relations-status-test ## QA steps See individual patches. ## Documentation changes See individual changes ## Bug reference None.
Description of change
There are outdated bugs around status and its ability to filter by machine id.
This PR proposes tests to ensure that the functionality was delivered, is functioning as expected and that we do not regress in the future.
These tests ensure that:
Bug reference
https://bugs.launchpad.net/juju/+bug/1748915
https://bugs.launchpad.net/juju/+bug/1584170