LXD: Set default server name #9121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So the idea of the following is to set a default server name, so that when we come to fill in the zones later on, the code in question can identify it correctly.
|
Currently this still fails to deploy the |
|
!!build!! |
1 similar comment
|
!!build!! |
hmlanigan
reviewed
Aug 28, 2018
| @@ -94,6 +94,13 @@ func NewServer(svr lxd.ContainerServer) (*Server, error) { | |||
|
|
|||
| name := info.Environment.ServerName | |||
| clustered := info.Environment.ServerClustered | |||
| if name == "" && !clustered { | |||
| // If the name is set to empty and clustering is false, then it's highly | |||
There was a problem hiding this comment.
Suggest adding the bug number, as a reason why name shouldn't be empty.
manadart
reviewed
Aug 29, 2018
The following check is not required for LXD 2.0 and causes failures when attempting to deploy a application to a machine. For LXD 3.0 it might make sense to enable this as it verifies the whole setup, but we can consider that overkill.
The LXD version API check is really verbose, like silly verboseness We'll drop the logging to Trace so it's still there if the levels are set at the right level.
|
QAing this one |
Even if we have no cluster available, we still want to find the instances first and if there are no instances at all the provisioner task needs to handle that case first.
The following ensures that the server name is indeed set correctly when the server name is empty. This is because LXD 2.0 returns no server name, as there was no concept of server name as there was only one server (not strictly true, but enough to understand the concept)
|
!!build!! |
hmlanigan
approved these changes
Aug 29, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
So the idea of the following is to set a default server name, so
that when we come to fill in the zones later on, the code in
question can identify it correctly.
From the code:
QA steps
Ensure that you've got LXD 2.0 installed (snap is the easiest way, removing
LXD 3.0.x from your system).
The following should not fail with the error
Documentation changes
n/a
Bug reference
https://bugs.launchpad.net/juju/+bug/1786309