Fix Failure in remoteRelationsSuite.TestRemoteDyingRelationsChangedError #9433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to be after all test arrangement has been executed. Also adds detail to failure output.
mitechie
approved these changes
Nov 9, 2018
|
|
|
Mongo couldn't start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This patch simply ensures that change event invocation for this test is executed after all the test arrangements have completed.
QA steps
I could get this test to fail in reasonable time before; it now passes consistently
Documentation changes
None.
Bug reference
https://bugs.launchpad.net/juju-core/+bug/1802277