Prevent error when using Legacy Leases #9576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following code ensures that we don't fail when attempting to use the old legacy leases.
jameinel
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
The fix looks correct to me, though I haven't actually run bootstrap to confirm.
The big question here is how we will test this.
I'm a bit mixed, feeling like it is both easy to break this accidentally (as we obviously did), but also not a code path that we really want to support for a long time.
Thoughts?
The error type from the API is not the same type as errors.NotImplemented error, as the pointers don't match. This is a shame, because crossing API boundaries is the necessity of juju.
|
!!build!! Lease failure on a mongo box, not entirely sure why. |
|
!!build!! |
1 similar comment
|
!!build!! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following code ensures that we don't fail when attempting to
use the old legacy leases.
QA steps
Documentation changes
This is a bug fix, not functionality has changed.
Bug reference
https://bugs.launchpad.net/juju/+bug/1808324