If SetSupportedContainers doesn't change the value, don't write to the db #9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e db On startup, machine agents call SetSupportedContainers. If that doesn't actually change the supported containers, no need to write to the database. This supersedes juju#9660 as it contains the full PR required - includes the landed juju/txn#49 changes as well.
hmlanigan
approved these changes
Jan 25, 2019
The following code just tests if the container types are in a different order, then we don't care and continue onwards as if they where in the same order. Tests where added to ensure that we test that path.
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Feb 2, 2019
#9704 ## Description of change Merge the 2.5 branch, including the following pull requests: #9702 Remove juju- prefix from k8s pod names #9698 Make raft logging more usefull #9616 hubwatcher cache removal #9691 raft metrics registration fix #9695 log try again errors as info #9678 API server metrics collector #9693 support more k8s specific pod attributes #9685 filtered access to leases in store #9692 fix k8s charm upgrades #9676 fix meter status watcher #9683 handle failures writing lease changes to database #9688 update juju txn dependency #9684 exit http worker after a timeout even if muxes are in use #9675 add raft transport dependencies #9672 optimise SetSupportedContainer db writes #9669 fix goroutine leak in log sink handler #9666 fix generation of operator tag for k8s docker images #9656 handle k8s app config in deploy ConfigYAML #9631 multi-cloud controllers #9638 add support for setting k8s service annotations ## QA steps bootstrap and deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
On startup, machine agents call SetSupportedContainers. If that
doesn't actually change the supported containers, no need to write
to the database.
This supersedes #9660 as it contains
the full PR required - includes the landed juju/txn#49
changes as well.
QA steps
You can use:
Documentation changes
None.
Bug reference
https://bugs.launchpad.net/juju/+bug/1812981