New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add a juju subcommand for backups. #97
Conversation
} | ||
|
||
type BackupCommand struct { | ||
/* XXX Shuld this really be an env-specific command? */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. You want to backup the data for a specific environment. Almost everything that "juju" does is in the context of 1 environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I'm not sure what I was thinking. :)
I like the structuring of the client code quite a bit. I'd make "run" a bit more clear about what it actually is. |
I don't think this is ready to be landed as in, and I don't think you need further reviews. So I'm going to close this for now. You're welcome to open it up again if you want more feedback, or when you feel it is ready to land, etc. |
re: API compatibility, you're referring to the potential disparity in capability between client and server, right? I spoke with Michael and it makes sense for me now. We'll sort that out. Michael's point to me was that for backups (and restore) the versions should line up. In that case, I guess making use of your API versioning could would make sense. :) |
Keep in mind that this changeset is dependent on Michael's addition of client.Backup(). So I hadn't intended on merging it as-is. I just wanted to get feedback. Mission accomplished and thank you! |
hmm, I've prepended "WIP:" to the summary but can't re-open the PR for some reason. It's probably going to be easier to just create a new pull request (and link to this one) than to try to debug github. :) |
Implement CharmStore.Get.
This will fit on top of the client API that Michael is writing.