New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upgrade lxd profile tests #9776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmlanigan
reviewed
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, haven't QA yet.
Drive by comments
hmlanigan
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
1 similar comment
|
Merged
jujubot
added a commit
that referenced
this pull request
Mar 1, 2019
#9819 ## Description of change Another ratchet of changes in 2.5 that need to be in develop. prdesc Merge pull request #9793 from jameinel/2.5-cleanup-volumes-1800872 prdesc Merge pull request #9788 from babbageclunk/raftlease-application-leaders prdesc Merge pull request #9786 from howbazaar/2.5-move-worker prdesc Merge pull request #9782 from jameinel/2.5-network-exit-1807615 prdesc Merge pull request #9781 from timClicks/2.5 prdesc Merge pull request #9778 from anastasiamac/current-controller-saga prdesc Merge pull request #9776 from SimonRichardson/lxd-sub-acceptance-test prdesc Merge pull request #9777 from anastasiamac/storage-err-fix-machine-removal-25 prdesc Merge pull request #9759 from wallyworld/k8s-ephemeral-storage prdesc Merge pull request #9773 from achilleasa/emit-errors-for-invalid-credential-names prdesc Merge pull request #9774 from achilleasa/backport-leader-unit-support-for-juju-run prdesc Merge pull request #9764 from manadart/2.5-maas-container-inherit-props prdesc Merge pull request #9761 from Veebers/update-cloud-controller prdesc Merge pull request #9770 from hmlanigan/2.5-lxd-profile ## QA steps See individual patches. ## Documentation changes See individual patches. ## Bug reference prdesc https://bugs.launchpad.net/juju/+bug/1800872 prdesc https://bugs.launchpad.net/juju/+bug/1807615 prdesc https://bugs.launchpad.net/juju/+bug/1786140 prdesc https://bugs.launchpad.net/juju/+bug/1813079 prdesc https://bugs.launchpad.net/juju/+bug/1702538 prdesc https://bugs.launchpad.net/juju/+bug/1816826 prdesc https://bugs.launchpad.net/juju/+bug/1815636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following upgrades a LXD charm from a bundle charm.
Also fixes some potential issues with subordinate units.
QA steps
Local LXD environments.yaml
Run the following (substitute the right arg):