Position services without annotations. #38
Conversation
|
Test PASSed. |
| serviceData := b.Services[name] | ||
| x, xerr := strconv.ParseFloat(serviceData.Annotations["gui-x"], 64) | ||
| y, yerr := strconv.ParseFloat(serviceData.Annotations["gui-y"], 64) | ||
| if xerr != nil || yerr != nil { | ||
| return nil, errgo.Newf("service %q does not have a valid position", name) | ||
| if serviceData.Annotations["gui-x"] == "" && serviceData.Annotations["gui-y"] == "" { |
There was a problem hiding this comment.
While unlikely should you also support the OR case here?
There was a problem hiding this comment.
I thought about it, but an x without a y still falls under the invalid clause below.
|
Looks good! 👍 With some trivials |
|
Test PASSed. |
QA
|
| "sort" | ||
| ) | ||
|
|
||
| // getPointOutside returns a point that is outside the hull of existing placed vertices so that an object can be placed on the canvas without overlapping others. |
There was a problem hiding this comment.
can you please limit the line length of comments to around about 70-80 characters?
|
👍 LGTM with minor thoughts. QA OK |
|
Thanks all |
|
Test PASSed. |
|
Build failed: Attempt to land pull request failed |
|
Build failed: Attempt to land pull request failed |
|
Build failed: Attempt to land pull request failed |
|
Build failed: Attempt to land pull request failed |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/jujusvg-merge |
Position services without annotations. This is a backwards compatible change to place services which do not have position annotations. It works on the case of a bundle with one/some missing service annotations as well as a bundle missing all annotations, both of which pass bundle proof.
|
@makyo The jujusvg-merge job was never set up to use different target branches. Yesterday I didn't realize you were trying to merge into v1. After some surgery it seems to work now. |
This is a backwards compatible change to place services which do not have position annotations. It works on the case of a bundle with one/some missing service annotations as well as a bundle missing all annotations, both of which pass bundle proof.