Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels to services #45

Merged
merged 3 commits into from
Feb 11, 2016
Merged

Add labels to services #45

merged 3 commits into from
Feb 11, 2016

Conversation

makyo
Copy link
Contributor

@makyo makyo commented Feb 10, 2016

No description provided.

@jujugui
Copy link
Contributor

jujugui commented Feb 10, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/jujusvg/62/
Test FAILed.

@anthonydillon
Copy link
Member

Looks nice!

@jujugui
Copy link
Contributor

jujugui commented Feb 10, 2016

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/jujusvg/63/
Test FAILed.

@makyo makyo changed the title SPIKE Add labels to services Add labels to services Feb 11, 2016
@jujugui
Copy link
Contributor

jujugui commented Feb 11, 2016

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
http://ci.jujugui.org:8080//job/jujusvg/65/
Test PASSed.

@makyo
Copy link
Contributor Author

makyo commented Feb 11, 2016

QA

Run go run examples/generatesvg.go examples/openstack.yaml > bundle.svg and ensure that the labels are in place:
nova-compute_amqp_rabbitmq-server_amqp_and_canvas_go_-__users_makyo_work_go_src_gopkg_in_juju_jujusvg_v1_-_atom

mhilton
mhilton reviewed Feb 11, 2016
View reviewed changes
canvas.go
@@ -107,6 +107,21 @@ func (s *service) usage(canvas *svg.SVG, iconIds map[string]string) {
`clip-path="url(#clip-`+s.name+`)"`,
)
}
name := s.name
if len(name) > 20 {
name = fmt.Sprintf("%s...", name[:17])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you thought about using … (ellipsis character) instead of ...?

@mhilton
Copy link
Contributor

mhilton commented Feb 11, 2016

👍

@anthonydillon
Copy link
Member

QA 👍

@makyo
Copy link
Contributor Author

makyo commented Feb 11, 2016

TY :shipit:

@jujugui
Copy link
Contributor

jujugui commented Feb 11, 2016

Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/jujusvg-merge

jujugui added a commit that referenced this pull request Feb 11, 2016
@jujugui
Merge pull request #45 from makyo/labels-spike
a60359d 
Add labels to services
@jujugui jujugui merged commit a60359d into juju:v1 Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makyo @jujugui @anthonydillon @mhilton