Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy bundle with overlays #510

Closed
heitorPB opened this issue Jun 22, 2021 · 2 comments · Fixed by #566
Closed

deploy bundle with overlays #510

heitorPB opened this issue Jun 22, 2021 · 2 comments · Fixed by #566

Comments

@heitorPB
Copy link

Hello,

I was going through the docs and did not find a way to model.deploy a bundle with overlays.

Am I missing something here?

@SimonRichardson
Copy link
Member

It probably needs to be added.

@cderici
Copy link
Member

cderici commented Oct 18, 2021

deploy bundle with overlays

@cderici cderici mentioned this issue Oct 22, 2021
6 tasks
jujubot added a commit that referenced this issue Nov 8, 2021
#566

### Description

This PR adds the support for overlays in bundle deployments.

Fixes #510 

This PR relies on a change in Juju's api for getting changes for bundles with overlays (multi-part yaml support), juju/juju#13448.

Jira card [#142](https://warthogs.atlassian.net/browse/JUJU-142)



### QA Steps

`tests/integration/test_model.py` includes some new tests for the added support.

```
tox -e integration -- tests/integration/test_model.py
```

### Notes & Discussion

Please do not merge yet, as a couple of small things need to be done/added for this to be ready to land:

- [x] Add a PR on Juju for `GetChange` juju/juju#13448
- [x] Land that PR on Juju
- [x] Charmstore bundles with `--overlay` argument, along with its test
- [x] A test for a multi-part overlay as an `--overlay` argument to a local bundle being deployed
- [x] A test for a multi-part overlay as an `--overlay` argument to a charmstore bundle being deployed
- [x] Make sure that we resolve and inline `config: include-file://` and `config: include-base64://` here in `pylibjuju` side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants