Patch/update schema juju 2.3 alpha1 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2017 13:00
Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
This verifies that integration tests pass locally on Juju 2.3-alpha1 Signed-off-by: Adam Stokes <battlemidget@users.noreply.github.com>
adam-stokes
force-pushed
the
patch/update-schema-juju-2.3-alpha1
branch
from
930c93c
to
2bf42e4
Compare
jujubot
added a commit
that referenced
this pull request
Nov 8, 2021
#566 ### Description This PR adds the support for overlays in bundle deployments. Fixes #510 This PR relies on a change in Juju's api for getting changes for bundles with overlays (multi-part yaml support), juju/juju#13448. Jira card [#142](https://warthogs.atlassian.net/browse/JUJU-142) ### QA Steps `tests/integration/test_model.py` includes some new tests for the added support. ``` tox -e integration -- tests/integration/test_model.py ``` ### Notes & Discussion Please do not merge yet, as a couple of small things need to be done/added for this to be ready to land: - [x] Add a PR on Juju for `GetChange` juju/juju#13448 - [x] Land that PR on Juju - [x] Charmstore bundles with `--overlay` argument, along with its test - [x] A test for a multi-part overlay as an `--overlay` argument to a local bundle being deployed - [x] A test for a multi-part overlay as an `--overlay` argument to a charmstore bundle being deployed - [x] Make sure that we resolve and inline `config: include-file://` and `config: include-base64://` here in `pylibjuju` side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.