Fix issue #335: Allow provisioning with non-"ubuntu" user #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue with the SSH provisioner, which previously always assumed there was an "ubuntu" user with sudo access available on the target machine. The provisioner will now honor the username passed to `model.add_machine`. Added an additional integration test for testing the root user, as well as modifying the existing integration test to use a randomized username w/sudo access.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
This patch fixes an issue with the SSH provisioner, which previously always assumed there was an "ubuntu" user with sudo access available on the target machine. The provisioner will now honor the username passed to `model.add_machine`. Added an additional integration test for testing the root user, as well as modifying the existing integration test to use a randomized username w/sudo access.
… into provision_user
|
@SimonRichardson @achilleasa can you two take a peek at this please and help progress it. |
|
!!build!! |
SimonRichardson
approved these changes
Aug 13, 2019
| - {} | ||
| sudo: ["ALL=(ALL) NOPASSWD:ALL"] | ||
| groups: adm, sudoers | ||
| """.format(test_user, public_key) |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue with the SSH provisioner, which previously
always assumed there was an "ubuntu" user with sudo access available on
the target machine.
The provisioner will now honor the username passed to
model.add_machine.Added an additional integration test for testing the root user, as well
as modifying the existing integration test to use a randomized username
w/sudo access.