Fix _resolve_charm errors #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That are accidentally introduced in juju#825. * _resolve_charm's force parameter is made optional * fixed the _resolve_charm calls in bundle.py to have less number of variables to unpack onto
|
/build |
|
Ok for this the only test that's failing is that ubuntu charm storage thing : so I think we can merge this to at least unblock the tests for other PRs to be able to run their CI tests |
jujubot
added a commit
that referenced
this pull request
May 11, 2023
#848 ## What's Changed * [JUJU-3253] add missing force in bundle deployment by @juanmanuel-tirado in #815 * [JUJU-3348] Fix assumes parsing by @juanmanuel-tirado in #820 * [JUJU-3404] Pass series info into origin for ResolveCharm by @cderici in #825 * Fix _resolve_charm errors by @cderici in #834 * [JUJU-3583] wait_for_idle to not block when enough units are ready by @cderici in #840 * [JUJU-3565] Expect and handle exceptions from the AllWatcher task by @cderici in #833 * Fixes to pass the CI problems regarding missing postgresql charm. by @juanmanuel-tirado in #847 * [JUJU-3641] Fix local charm base channel discovery by @cderici in #846 [JUJU-3253]: https://warthogs.atlassian.net/browse/JUJU-3253?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3348]: https://warthogs.atlassian.net/browse/JUJU-3348?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3404]: https://warthogs.atlassian.net/browse/JUJU-3404?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3583]: https://warthogs.atlassian.net/browse/JUJU-3583?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3565]: https://warthogs.atlassian.net/browse/JUJU-3565?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [JUJU-3641]: https://warthogs.atlassian.net/browse/JUJU-3641?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds some changes to fix some errors about the
_resolve_charmmethod that are accidentally introduced in #825._resolve_charmforce parameter is made optional_resolve_charmcalls in thebundle.pyto have less number of variables to unpack ontoQA Steps
The ones that are
FAILEDin #825's CI run need to be passing.In fact all of the CI tests need to pass.