Fix spelling mistake #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following originally aimed to fix the "sofware" -> "software" spelling mistake. To prevent this happening again, tests where added to verify this and in doing so, also spotted other errors with in the origin file. Additional tests where then added to make sure that those ones also don't break in the future. Summary: - software spelling fix - OriginEnterpriseID error not being returned - OriginEnterpriseID path returned partial or missing items in the path
SimonRichardson
added a commit
to SimonRichardson/juju
that referenced
this pull request
May 9, 2018
The following change just ignores this miss-spelling until the following PR lands juju/rfc#2
howbazaar
approved these changes
May 9, 2018
|
Canonical servers seem to be having some difficulties today, but if we want, I can set up a bot for merge support. I'm guessing this doesn't already have one. |
|
No it doesn't, so adding it would be great. Thank you |
The following adds a Makefile along with the fixes that where found adding the checking. This is a precusor to adding gometalinter to all the repos we have. Although it's found serious issue in the private.go file to warrent the immediate inclusion.
|
I've added another commit to this PR, which finds another issue with a orphan |
The following is required by the CI server in order to install the dependencies in a standardised way, that is similar to other juju repos.
|
|
SimonRichardson
added a commit
to SimonRichardson/juju
that referenced
this pull request
May 11, 2018
The following change just ignores this miss-spelling until the following PR lands juju/rfc#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following originally aimed to fix the "sofware" -> "software"
spelling mistake. To prevent this happening again, tests where added
to verify this and in doing so, also spotted other errors with in the
origin file. Additional tests where then added to make sure that those
ones also don't break in the future.
Summary: