fix parse for tags w/ double digit patch numbers #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,14 +45,13 @@ func (*suite) TestCompare(c *gc.C) { | |||
| {"2.0.0.0", "2.0.0.0", 0}, | |||
| {"2.0.0.1", "2.0.0.0", 1}, | |||
| {"2.0.1.10", "2.0.0.0", 1}, | |||
| {"2.0-_0", "2.0-00", 1}, | |||
There was a problem hiding this comment.
this was removed because 2.0-00 is not actually a valid version, so it errors out (it has a zero length tag specified). It used to work because the tag was getting parsed as "0"
|
LGTM. Lets make the tag match just |
We don't actually want anything but a-z in the tag name
jujubot
added a commit
to juju/charm
that referenced
this pull request
Sep 15, 2016
Update test to match changed juju/version behaviour Since commit [4ae6172](juju/version@4ae6172) (juju/version#3), `version.Number.Tag` will never include any digits, so this test became incorrect.
natefinch
added a commit
that referenced
this pull request
Sep 16, 2016
This makes the code a little easier to follow, and we remove the nested groups which are kind of confusing.
natefinch
added a commit
that referenced
this pull request
Sep 16, 2016
This makes the code a little easier to follow, and we remove the nested groups which are kind of confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the tag group (\w+) would consume all but the last digit of the patch, because \w+ matches numbers as well as letters. In talking to Martin, we're pretty sure we don't need to match anything but a-z for the tag name, so I changed it to that, and fixed the tests to match this assumption.