-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the force_latest_compatible_version
input, and add the "auto-detect Dependabot/CompatHelper" functionality
#20
Conversation
4829b5d
to
717e753
Compare
Maybe there should be a version check if the feature is turned on? If we're less than 1.7, print a warning or something. |
Good idea! Take a look at the commit I just pushed - does that meet the requirement? |
If it looks good, I'll add it to the other PR as well. |
I wonder if instead of adding individual inputs for |
I don't feel strongly either way. What do you think users would prefer? |
So, we've already added individual inputs for:
So I think probably it would be easiest to just keep the convention of having individual inputs? |
Sounds good. Changes look good to me, I'll merge when the JuliaLang/Pkg.jl#2176 is merged (and leave it on change request until then to prevent accidental merges) |
90c0f1d
to
9dedb33
Compare
force_latest_compat
inputforce_latest_compat
input, and add the "auto-detect Dependabot" fun ctionality
force_latest_compat
input, and add the "auto-detect Dependabot" fun ctionalityforce_latest_compat
input, and add the "auto-detect Dependabot" functionality
9dedb33
to
27f1194
Compare
I've added the "auto-detect Dependabot/CompatHelper" functionality from JuliaLang/Pkg.jl#2234 @christopher-dG @SaschaMann Can you review again? |
c68abcd
to
b39b62e
Compare
Should this be considered a breaking change and require a major version bump of the action? |
Hmmm. The only change in behavior is on CompatHelper/Dependabot PRs, right? Dependabot doesn't exist yet. And for CompatHelper, this was always supposed to be the intended behavior, so honestly I would consider it to be a bug fix. |
As long as the behavior change is only on Dependabot/CompatHelper PRs, I would say this "technically is a breaking change in behavior, but really it's intended to be a bug fix, so it's okay to do it in a patch release". |
@SaschaMann Take a look now. |
We'll need to wait to merge until the macOS nightlies are fixed. |
Alright the macOS buildbots are fixed and the macOS nightlies are up to date. This is good to merge from my end. |
@SaschaMann Could we make a new |
You beat me to it 😂 https://github.com/julia-actions/julia-runtest/releases/tag/v1.6.0 |
@SaschaMann and @christopher-dG thank you for your help on this! |
I probably should have mentioned that I'm gonna tag it :D I usually do that right after merging PRs to these actions, I should probably setup a merge-and-tag script at some point. |
🚀 🚀 🚀 it works!!! https://github.com/cscherrer/SossMLJ.jl/runs/2241088439 (triggered by cscherrer/SossMLJ.jl#132)
|
This could be useful! |
This should not be merged until JuliaLang/Pkg.jl#2439 is merged.