Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the force_latest_compatible_version input, and add the "auto-detect Dependabot/CompatHelper" functionality #20

Merged
merged 9 commits into from
Mar 31, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Nov 2, 2020

This should not be merged until JuliaLang/Pkg.jl#2439 is merged.

action.yml Outdated Show resolved Hide resolved
@christopher-dG
Copy link
Member

Maybe there should be a version check if the feature is turned on? If we're less than 1.7, print a warning or something.

@DilumAluthge
Copy link
Member Author

Maybe there should be a version check if the feature is turned on? If we're less than 1.7, print a warning or something.

Good idea! Take a look at the commit I just pushed - does that meet the requirement?

@DilumAluthge
Copy link
Member Author

If it looks good, I'll add it to the other PR as well.

action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@SaschaMann
Copy link
Member

I wonder if instead of adding individual inputs for Pkg.test(;kwargs...) we should take a single input for all kwargs? Or add inputs for every kwarg?

@DilumAluthge
Copy link
Member Author

I wonder if instead of adding individual inputs for Pkg.test(;kwargs...) we should take a single input for all kwargs? Or add inputs for every kwarg?

I don't feel strongly either way. What do you think users would prefer?

@DilumAluthge
Copy link
Member Author

I wonder if instead of adding individual inputs for Pkg.test(;kwargs...) we should take a single input for all kwargs? Or add inputs for every kwarg?

So, we've already added individual inputs for:

  • coverage
  • depwarn
  • inline

So I think probably it would be easiest to just keep the convention of having individual inputs?

@SaschaMann
Copy link
Member

Sounds good.

Changes look good to me, I'll merge when the JuliaLang/Pkg.jl#2176 is merged (and leave it on change request until then to prevent accidental merges)

action.yml Outdated Show resolved Hide resolved
@DilumAluthge DilumAluthge force-pushed the dpa/pkg-test-force_latest_compat branch from 90c0f1d to 9dedb33 Compare November 24, 2020 18:28
@DilumAluthge DilumAluthge changed the title Add the force_latest_compat input Add the force_latest_compat input, and add the "auto-detect Dependabot" fun ctionality Nov 24, 2020
@DilumAluthge DilumAluthge changed the title Add the force_latest_compat input, and add the "auto-detect Dependabot" fun ctionality Add the force_latest_compat input, and add the "auto-detect Dependabot" functionality Nov 24, 2020
@DilumAluthge DilumAluthge force-pushed the dpa/pkg-test-force_latest_compat branch from 9dedb33 to 27f1194 Compare November 24, 2020 18:44
@DilumAluthge
Copy link
Member Author

I've added the "auto-detect Dependabot/CompatHelper" functionality from JuliaLang/Pkg.jl#2234

@christopher-dG @SaschaMann Can you review again?

action.yml Outdated Show resolved Hide resolved
autodetect-dependabot.jl Outdated Show resolved Hide resolved
autodetect-dependabot.jl Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
@SaschaMann
Copy link
Member

Should this be considered a breaking change and require a major version bump of the action?

@DilumAluthge
Copy link
Member Author

Hmmm. The only change in behavior is on CompatHelper/Dependabot PRs, right?

Dependabot doesn't exist yet.

And for CompatHelper, this was always supposed to be the intended behavior, so honestly I would consider it to be a bug fix.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Nov 24, 2020

As long as the behavior change is only on Dependabot/CompatHelper PRs, I would say this "technically is a breaking change in behavior, but really it's intended to be a bug fix, so it's okay to do it in a patch release".

@DilumAluthge
Copy link
Member Author

@SaschaMann Take a look now.

@DilumAluthge
Copy link
Member Author

We'll need to wait to merge until the macOS nightlies are fixed.

@DilumAluthge
Copy link
Member Author

Alright the macOS buildbots are fixed and the macOS nightlies are up to date.

This is good to merge from my end.

@SaschaMann

@SaschaMann SaschaMann merged commit eda4346 into master Mar 31, 2021
@SaschaMann SaschaMann deleted the dpa/pkg-test-force_latest_compat branch March 31, 2021 21:56
@DilumAluthge
Copy link
Member Author

DilumAluthge commented Mar 31, 2021

@SaschaMann Could we make a new v1.x.y tag and release?

@DilumAluthge
Copy link
Member Author

You beat me to it 😂

https://github.com/julia-actions/julia-runtest/releases/tag/v1.6.0

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Mar 31, 2021

@SaschaMann and @christopher-dG thank you for your help on this!

@SaschaMann
Copy link
Member

I probably should have mentioned that I'm gonna tag it :D

I usually do that right after merging PRs to these actions, I should probably setup a merge-and-tag script at some point.

@DilumAluthge
Copy link
Member Author

🚀 🚀 🚀 it works!!!

https://github.com/cscherrer/SossMLJ.jl/runs/2241088439 (triggered by cscherrer/SossMLJ.jl#132)

┌ Error: Package is not at the latest compatible version
│   name = "CategoricalArrays"
│   uuid = UUID("324d7699-5711-5eae-9e2f-1d82baa6b597")
│   compat_entry_string = "0.8, 0.9"
│   active_version = v"0.8.3"
│   latest_compatible_version = v"0.9.4"
│   earliest_backwards_compatible_version = v"0.9.0"
│   allow_earlier_backwards_compatible_versions = true
└ @ Pkg.Operations /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Pkg/src/Operations.jl:1856
ERROR: One or more direct dependencies is not at the latest compatible version

@DilumAluthge
Copy link
Member Author

I should probably setup a merge-and-tag script at some point.

This could be useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants