Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set force_latest_compat=true by default on Dependabot/CompatHelper PRs, and set force_latest_compat=false by default otherwise #2234

Closed
wants to merge 3 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Nov 23, 2020

This pull request is made against #2176

You can view the correct diff (#2234 against #2176) at this link: https://github.com/DilumAluthge/Pkg.jl/compare/dpa/force-latest-compat...dpa/autodetect-dependabot

@DilumAluthge
Copy link
Member Author

@christopher-dG Can you review this?

@DilumAluthge DilumAluthge marked this pull request as draft November 23, 2020 21:12
@christopher-dG
Copy link
Member

I think you set the target branch to master.

@DilumAluthge
Copy link
Member Author

DilumAluthge commented Nov 23, 2020

I think you set the target branch to master.

Yeah. GitHub won't let me set the target branch to dpa/force-latest-compat because the branch is in a fork.

@DilumAluthge
Copy link
Member Author

You can view the correct diff (#2234 against #2176) at this link: https://github.com/DilumAluthge/Pkg.jl/compare/dpa/force-latest-compat...dpa/autodetect-dependabot

@KristofferC
Copy link
Sponsor Member

KristofferC commented Nov 24, 2020

I must say, I am quite uncomfortable hard coding stuff like this into Pkg. There are going to be a lot of bots written for Julia running on a lot of different CI services and there can't be a need to code in all those combinations into Pkg itself. So, there must be some better option than this, like having this logic in the CI file and pass the argument to Pkg.test based on that, just like how other options are passed to functions running on CI.

@fredrikekre
Copy link
Member

I agree (had a similar comment already written in a review that I failed to post...).

@christopher-dG
Copy link
Member

The problem with that is it's 1 fix vs N fixes where N is the number of Julia packages. As great as it would be if everyone instantly updated their CI configs when it was needed, that just doesn't happen. Which is fine, since it's their responsibility, but it's still going to annoy and confuse loads of people.

@KristofferC
Copy link
Sponsor Member

CompatBot could try update the CI file?

@DilumAluthge
Copy link
Member Author

CompatBot could try update the CI file?

It would have to be Dependabot. @christopher-dG Is that feasible?

@DilumAluthge
Copy link
Member Author

Actually, here's one option: if users use the julia-runtest action, we could implement this "autodetect" logic there.

This would automatically cover most people using GitHub Actions.

Travis and AppVeyor people will need to fix their scripts manually.

@christopher-dG
Copy link
Member

I think encoding this in CI scripts (the ones that go in people's repos) is a non-starter. Doing it once per CI provider seems okay, and it's not tied to Julia releases then.

@DilumAluthge
Copy link
Member Author

@christopher-dG If it's okay with you, I'll close this PR, and I'll work on adding this "autodetect" functionality into the julia-runtest GitHub Action.

@DilumAluthge
Copy link
Member Author

I've moved the "auto-detect Dependabot/CompatHelper" functionality into julia-actions/julia-runtest#20, so I have closed this PR.

@SaschaMann
Copy link

Travis and AppVeyor people will need to fix their scripts manually.

You could potentially add it to Travis here: https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/script/julia.rb

@christopher-dG
Copy link
Member

Pretty much everyone using AppVeyor is doing so via AppVeyor.jl. GHA+Travis+AppVeyor probably covers >95% of open source package CI.

@DilumAluthge
Copy link
Member Author

See JuliaRegistries/CompatHelper.jl#298 to track the deployment of the force_latest_compatible_version feature across the most commonly used CI platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants