New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI for setting compiled funcs/mods #1888
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
744eca4
UI for setting compiled funcs/mods
pfitzseb 545680d
improvements
pfitzseb 426b243
also support launched debugger
pfitzseb 6e70a25
stop abusing bp API for compiled mode
pfitzseb 15687b1
support interpreted methods
pfitzseb 69757b9
update interpreted methods
pfitzseb 269fcff
Apply suggestions from code review
pfitzseb 0a70cee
Merge branch 'master' into sp/compileds
pfitzseb 302f917
better defaults
pfitzseb fe0180c
rm console.log
pfitzseb 4c0090f
Merge branch 'master' into sp/compileds
pfitzseb File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule CSTParser
updated
21 files
+0 −5 | .github/pull_request_template.md | |
+1 −1 | .github/workflows/jlpkgbutler-ci-master-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-ci-pr-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-codeformat-pr-workflow.yml | |
+2 −2 | Project.toml | |
+0 −1 | README.md | |
+16 −20 | src/CSTParser.jl | |
+19 −31 | src/components/internals.jl | |
+3 −2 | src/components/keywords.jl | |
+5 −13 | src/components/operators.jl | |
+3 −2 | src/components/strings.jl | |
+8 −12 | src/conversion.jl | |
+3 −3 | src/interface.jl | |
+18 −44 | src/iterate.jl | |
+1 −1 | src/recovery.jl | |
+3 −11 | src/spec.jl | |
+12 −31 | src/utils.jl | |
+3 −8 | test/errparse.jl | |
+1 −46 | test/iterate.jl | |
+3 −93 | test/parser.jl | |
+0 −4 | test/spec.jl |
Submodule DebugAdapter
updated
9 files
Submodule DocumentFormat
updated
9 files
+0 −5 | .github/pull_request_template.md | |
+1 −1 | .github/workflows/jlpkgbutler-ci-master-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-ci-pr-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-codeformat-pr-workflow.yml | |
+1 −1 | Project.toml | |
+4 −31 | src/DocumentFormat.jl | |
+10 −14 | src/indents.jl | |
+2 −1 | src/passes.jl | |
+0 −31 | test/runtests.jl |
Submodule FilePathsBase
updated
16 files
+0 −80 | .github/workflows/CI.yml | |
+0 −16 | .github/workflows/CompatHelper.yml | |
+26 −0 | .travis.yml | |
+1 −1 | Project.toml | |
+1 −1 | README.md | |
+14 −22 | docs/Manifest.toml | |
+1 −1 | docs/Project.toml | |
+5 −7 | docs/make.jl | |
+3 −1 | src/FilePathsBase.jl | |
+1 −1 | src/aliases.jl | |
+0 −1 | src/buffer.jl | |
+2 −2 | src/libc.jl | |
+1 −1 | src/path.jl | |
+7 −9 | src/test.jl | |
+0 −7 | test/buffer.jl | |
+4 −23 | test/system.jl |
Submodule JSONRPC
updated
6 files
Submodule JuliaInterpreter
updated
16 files
+5 −1 | .github/workflows/CI.yml | |
+1 −1 | Project.toml | |
+21 −75 | docs/Manifest.toml | |
+0 −2 | docs/src/dev_reference.md | |
+22 −24 | docs/src/index.md | |
+1 −1 | src/breakpoints.jl | |
+1 −2 | src/commands.jl | |
+13 −20 | src/construct.jl | |
+4 −8 | src/interpret.jl | |
+5 −4 | src/localmethtable.jl | |
+11 −15 | src/optimize.jl | |
+0 −8 | src/types.jl | |
+9 −15 | src/utils.jl | |
+4 −28 | test/debug.jl | |
+0 −6 | test/eval_code.jl | |
+3 −59 | test/interpret.jl |
Submodule LanguageServer
updated
21 files
+0 −5 | .github/pull_request_template.md | |
+1 −1 | .github/workflows/jlpkgbutler-ci-master-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-ci-pr-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-codeformat-pr-workflow.yml | |
+12 −20 | src/document.jl | |
+1 −9 | src/exception_types.jl | |
+52 −91 | src/languageserverinstance.jl | |
+1 −5 | src/protocol/completion.jl | |
+0 −1 | src/protocol/messagedefs.jl | |
+10 −12 | src/requests/actions.jl | |
+23 −47 | src/requests/completions.jl | |
+20 −75 | src/requests/features.jl | |
+10 −25 | src/requests/hover.jl | |
+14 −20 | src/requests/init.jl | |
+1 −8 | src/requests/misc.jl | |
+0 −2 | src/requests/signatures.jl | |
+17 −29 | src/requests/textdocument.jl | |
+13 −6 | src/requests/workspace.jl | |
+1 −1 | src/staticlint.jl | |
+7 −33 | src/utilities.jl | |
+1 −1 | test/runtests.jl |
Submodule LoweredCodeUtils
updated
5 files
+1 −1 | Project.toml | |
+131 −187 | src/codeedges.jl | |
+2 −33 | src/utils.jl | |
+2 −29 | test/codeedges.jl | |
+27 −27 | test/signatures.jl |
Submodule OrderedCollections
updated
12 files
+0 −46 | .github/workflows/CI.yml | |
+0 −18 | .github/workflows/Documenter.yml | |
+2 −6 | .github/workflows/TagBot.yml | |
+22 −0 | .travis.yml | |
+1 −1 | Project.toml | |
+43 −0 | appveyor.yml | |
+1 −1 | src/OrderedCollections.jl | |
+4 −4 | src/little_dict.jl | |
+14 −55 | src/ordered_dict.jl | |
+0 −1 | src/ordered_set.jl | |
+2 −28 | test/test_little_dict.jl | |
+0 −22 | test/test_ordered_dict.jl |
Submodule Revise
updated
9 files
+2 −2 | Project.toml | |
+2 −1 | README.md | |
+1 −1 | src/callbacks.jl | |
+1 −2 | src/lowered.jl | |
+0 −8 | src/packagedef.jl | |
+48 −60 | src/precompile.jl | |
+1 −1 | src/types.jl | |
+2 −118 | test/runtests.jl | |
+1 −3 | test/sigtest.jl |
Submodule StaticLint
updated
14 files
+0 −5 | .github/pull_request_template.md | |
+1 −1 | .github/workflows/jlpkgbutler-ci-master-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-ci-pr-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-codeformat-pr-workflow.yml | |
+0 −21 | src/StaticLint.jl | |
+20 −42 | src/bindings.jl | |
+2 −18 | src/imports.jl | |
+26 −197 | src/linting/checks.jl | |
+3 −23 | src/macros.jl | |
+52 −25 | src/references.jl | |
+1 −3 | src/scope.jl | |
+49 −88 | src/type_inf.jl | |
+3 −39 | src/utils.jl | |
+8 −288 | test/runtests.jl |
Submodule SymbolServer
updated
12 files
+0 −5 | .github/pull_request_template.md | |
+1 −1 | .github/workflows/jlpkgbutler-ci-master-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-ci-pr-workflow.yml | |
+1 −1 | .github/workflows/jlpkgbutler-codeformat-pr-workflow.yml | |
+39 −63 | registryindexer/main.jl | |
+2 −2 | src/SymbolServer.jl | |
+1 −1 | src/faketypes.jl | |
+0 −5 | src/indexpackage.jl | |
+3 −3 | src/serialize.jl | |
+0 −10 | src/symbols.jl | |
+11 −19 | src/utils.jl | |
+2 −7 | test/runtests.jl |
Submodule Tokenize
updated
5 files
+1 −1 | Project.toml | |
+18 −50 | src/lexer.jl | |
+1 −69 | src/token_kinds.jl | |
+3 −21 | src/utilities.jl | |
+13 −69 | test/lexer.jl |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these by defining module, or by namespace module?
i.e. will this also compile my overoads of
Base.map(f, ::MyType)
etc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are for all methods of that function, so
-Base.map
will force interpreted mode for all overloads.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should look into working out how to do it by definitition location, but that can be a follow up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this list could be method based instead of function based, but I'm not sure whether that's particularly useful.