Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] The layout doesn't work well for a horizontal pane #8

Closed
huyz opened this issue Jul 10, 2022 · 1 comment
Closed

[bug] The layout doesn't work well for a horizontal pane #8

huyz opened this issue Jul 10, 2022 · 1 comment

Comments

@huyz
Copy link

huyz commented Jul 10, 2022

It seems the layout was designed to have the video in a tall vertical pane on the side. The video is stretched horizontally within the note. In my Obsidian, that's wasteful as most of the bottom of that pane is just whitespace.

Videos tend to be more wide than tall. So it makes sense to me to try to move the video pane to the bottom of my app and make it horizontal instead. Especially since I have a 2-pane side-by-side layout usually, I can basically try to dedicate the bottom-left quadrant of my screen to the Timestamp Video pane; then that would minimize the amount of wasteful white space.

Unfortunately, for some reason the video is squished from the bottom and ends up looking like this:

screenshot 2022-07-10T135502Z

Can't really see much.

@enly1
Copy link

enly1 commented Jul 22, 2022

The issue here is it seems to be setting the video frame height to a small portion of the pane height. If you make the pane taller, it scales the video a bit, but should just use the available space more efficiently. Then it would be great.
I did find undocking it and putting it in the main edit space provided an option for me to get a viewable size video; however, 1/4 of the screen then is wasted.

Suspect some minor tweaks would fix this up nicely.

ps - Was viewing a youtube video also.

juliang22 added a commit that referenced this issue Jul 24, 2022
closes #7, closes #8; add functionality for seeking forward and backward
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants