Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed viewer height to 100% #11

Merged
merged 1 commit into from Jul 24, 2022
Merged

Conversation

enly1
Copy link

@enly1 enly1 commented Jul 23, 2022

Changes of video player size definition so youtube videos render using full pane size and scale appropriately.

My personal fix for #8

FYI - Only tried with youtube videos, but works perfectly for them.
Your mileage may vary.

@juliang22
Copy link
Owner

Thanks for taking a stab at fixing this issue, really appreciate all the contributions!

For an optimal solution, I'd love if the video player was able to scale up its height depending on the width. Not sure if this is possible, but this would definitely be ideal as there wouldn't be any of those annoying black bars popping up. I'll approve this in the meantime to fix this issue, but if you want to look into that, that would be fantastic!

@juliang22 juliang22 merged commit 2542ac9 into juliang22:master Jul 24, 2022
@enly1
Copy link
Author

enly1 commented Jul 24, 2022

Thanks for taking a stab at fixing this issue, really appreciate all the contributions!

For an optimal solution, I'd love if the video player was able to scale up its height depending on the width. Not sure if this is possible, but this would definitely be ideal as there wouldn't be any of those annoying black bars popping up. I'll approve this in the meantime to fix this issue, but if you want to look into that, that would be fantastic!

For me, this doesn't make any sense - but I also use a dark theme, so its black already.

But - given the panel is already a fixed size, the only way this would seem to logically work would be to resize the panel dimensions, which doesn't make any sense to me. Maybe I'm missing something here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants