Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override functions from StatsBase #23

Closed
nalimilan opened this issue Jun 2, 2018 · 4 comments
Closed

Override functions from StatsBase #23

nalimilan opened this issue Jun 2, 2018 · 4 comments
Milestone

Comments

@nalimilan
Copy link
Contributor

In the perspective of adding Bootstrap.jl to the list of default packages in Stats.jl (JuliaStats/StatsKit.jl#4), it would be nice to use the confint and stderror functions from StatsBase instead of ci and se, and to add a method to StatsBase.nobs instead of defining a separate function.

@juliangehring
Copy link
Owner

juliangehring commented Jun 4, 2018

Thanks for raising this, I wasn't aware of Stats.jl. I fully agree with your suggestions, the package can and should integrate better with StatsBase. I'll try to add these soon (possibly in combination with other interface related changes).

@juliangehring
Copy link
Owner

Since nobs is only used internally by the Bootstrap package, is having a general nobs in StatsBase very relevant? I'm not sure if there is a wide use for these methods; but if there is a broader interest, I'm happy to have it live in StatsBase.

@nalimilan
Copy link
Contributor Author

Thanks. If nobs is internal then it's fine to keep it as is. It can always be exported later if needed.

@juliangehring
Copy link
Owner

Alright, all the renaming has been merged with #24.

@juliangehring juliangehring added this to the v1.3.0 milestone Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants