Integrate better with StatsBase function names #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliangehring
force-pushed
the
statsbase-integration
branch
from
77a818c
to
644d63f
Compare
Integrates with the naming of the respective functions in `StatsBase.jl`. The old function names have been deprecated.
juliangehring
force-pushed
the
statsbase-integration
branch
from
644d63f
to
087812e
Compare
|
This should take care of the main aspects of #23. @nalimilan Does this look good to you? |
|
Yes, thanks! |
This was referenced Sep 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates with the naming of the equivalent functions in
StatsBase.jl: Renamescitoconfintandsetostderror. The old function names have been deprecated, and will be supported until the next major release. The motivation for these change is outlined in #23.