Multi worker setup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+7
to
+15
| resource_user_key = "#{resource.to_gid}:#{user.to_gid}" | ||
| digested_block_key = ActiveSupport::Digest.hexdigest("#{block_location}:#{resource_user_key}") | ||
|
|
||
| # the store item (identified by block location, resource, and user) might already be present | ||
| store_item = Cubism.store[digested_block_key] || Cubism::BlockStoreItem.new( | ||
| block_location: block_location, | ||
| resource_gid: resource.to_gid.to_s, | ||
| user_gid: user.to_gid.to_s | ||
| ) |
There was a problem hiding this comment.
Perhaps an almost meaningless "optimization", but we don't need to get the gid twice for resource and user:
Suggested change
| resource_user_key = "#{resource.to_gid}:#{user.to_gid}" | |
| digested_block_key = ActiveSupport::Digest.hexdigest("#{block_location}:#{resource_user_key}") | |
| # the store item (identified by block location, resource, and user) might already be present | |
| store_item = Cubism.store[digested_block_key] || Cubism::BlockStoreItem.new( | |
| block_location: block_location, | |
| resource_gid: resource.to_gid.to_s, | |
| user_gid: user.to_gid.to_s | |
| ) | |
| resource_gid = resource.to_gid.to_s | |
| user_gid = user.to_gid.to_s | |
| resource_user_key = [resource_gid, user_gid].join(":") | |
| digested_block_key = ActiveSupport::Digest.hexdigest("#{block_location}:#{resource_user_key}") | |
| # the store item (identified by block location, resource, and user) might already be present | |
| store_item = Cubism.store[digested_block_key] || Cubism::BlockStoreItem.new( | |
| block_location: block_location, | |
| resource_gid: resource_gid, | |
| user_gid: user_gid | |
| ) |
There was a problem hiding this comment.
Thanks! Seemingly I can't commit to an already merged PR though 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
Previously, blocks were fetched from a singleton which (obviously) cannot work across multiple processes.
This PR introduces a way to extract the actual ERB source of the cubism block via a
Preprocessorand actually render it inline inBroadcaster. Since kredis is in the picture already, it is used to store the block location, source, as well as resource and user IDs under a combined hashed key.