stop command doesn't seem to handle queue param properly

[SkidX]

Hi,
If I have two concurrent tweens on the same target (obviously animating different CSS properties), for example:

$target.velocity({left: 200}, {duration: 1000, queue: 'a'}).dequeue('a');
$target.velocity({top: 300}, {duration: 2000, queue: 'b'}).dequeue('b');

then using stop command with the aim to halt only one of them does not seem to work:
$target.velocity('stop', 'a');
It halts all the queues, not only 'a'.

With jQuery native animate it works as expected, stopping only 'a' while the other tween continues its run.

[julianshapiro]

I'll have this fixed in the next 2-3 days. Thank you.

[SkidX]

Thank you for fixing it :)

[julianshapiro]

Fixed. Stay tuned for the next release.

[julianshapiro]

Please test, confirm it works, and get back to me. Thank you so much!

[SkidX]

I cannot do deep test right now (it's night here), but as far as I seen doing some quick tests it seems to work perfectly now. Thanks.

[SkidX]

Sorry, too tired yesterday, I've done the wrong test.
It is not working as expected.
Check this to see
http://jsfiddle.net/hct1n31x/1/

[julianshapiro]

Your test had multiple problems, including using $test instead of $v for the stopping. But it's revealed another bug that i'll look into. http://jsfiddle.net/hct1n31x/2/

[SkidX]

yeah, sorry, cut & paste mistake.

[julianshapiro]

Done. Please test, confirm it works, and get back to me. Thank you so much!

[SkidX]

I've tested it locally and the bug seems solved now.

However I've noticed that now if you use a custom queue it does not put animation data in velocity.tweensContainer object inside element's data structure, it is null now, while it fills it properly if you stay on default queue.
Is this behavior needed or maybe is just a side effect?
I was relying on those data for doing a particular thing, so for me is a little bit troublesome now.

[julianshapiro]

Correct. If you see the new documentation on velocity's reverse command, you'll see a new change has been made: only the default effects queue affects the stored tweensContainer (which is used for reversal).

Hopefully you don't mind figuring out a way around that :)

[SkidX]

ok.
So, please correct me if I'm wrong, only when using default queue it will benefit from cached values, while if I use custom queues (or no queues) it has to query the DOM in order to know start and end values of properties, right?

[julianshapiro]

That is correct. Great question. It's not impossible for me to allow for multiple cached value chains (one per queue), but custom queuing is uncommon so it's not a concern of mine at this time.

Sent from my phone

On Aug 25, 2014, at 10:01 AM, Federico Orrù notifications@github.com wrote:

ok.
So, please correct me if I'm wrong, only when using default queue it will benefit from cached values, while if I use custom queues (or no queues) it has to query the DOM in order to know start and end values of properties, right?

—
Reply to this email directly or view it on GitHub.

[SkidX]

fair enough :)

Thanks for the fix and explanations.

[julianshapiro]

Any time

Sent from my phone

On Aug 25, 2014, at 10:15 AM, Federico Orrù notifications@github.com wrote:

fair enough :)

Thanks for the fix and explanations.

—
Reply to this email directly or view it on GitHub.