Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only one interval instance for zero_itv / sym_itv #3495

Open
schillic opened this issue Apr 19, 2024 · 0 comments · May be fixed by #3609
Open

Use only one interval instance for zero_itv / sym_itv #3495

schillic opened this issue Apr 19, 2024 · 0 comments · May be fixed by #3609
Assignees
@schillic
Labels
refactoring 🔧 Internal code changes, typically no impact on API

Comments

@schillic
Copy link
Member

In #3447 we added convenience functions from ReachabilityAnalysis to construct important intervals (zero_itv/sym_itv). They were generalized to other numeric types; hence currently every call creates a new instance. We should have a dictionary instead that stores these instances, or just store the Float64 one because that is the one we would use in practice.
@schillic schillic added the refactoring 🔧 Internal code changes, typically no impact on API label Apr 19, 2024
@schillic schillic linked a pull request Jul 23, 2024 that will close this issue
Open
@schillic schillic self-assigned this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
refactoring 🔧 Internal code changes, typically no impact on API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3495 - Avoid repeated creation of zero_box/sym_box JuliaReach/LazySets.jl
1 participant
@schillic