Simplify get_sentiments() #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
+ Coverage 80.15% 81.26% +1.11%
==========================================
Files 13 13
Lines 388 379 -9
==========================================
- Hits 311 308 -3
+ Misses 77 71 -6
Continue to review full report at Codecov.
|
|
Thanks so much for this improvement! 🙌 |
juliasilge
pushed a commit
that referenced
this pull request
Sep 7, 2019
|
Would you mind if I used this as small case study in https://principles.tidyverse.org? |
juliasilge
pushed a commit
that referenced
this pull request
Sep 8, 2019
|
@hadley Sure thing! I'm really glad to have all these repetitions of |
|
Thanks @juliasilge! |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following a thread that started with R Packages revisions, then went to
available::available(), which had me poking here. This seemed like a great candidate for a littleswitch()action 🙂The error messages lost a bit of specific verbiage/capitalization, which I could restore if that seems worth it.