Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vignettes with alt text #233

Merged
merged 8 commits into from
Mar 23, 2023
Merged

Update vignettes with alt text #233

merged 8 commits into from
Mar 23, 2023

Conversation

juliasilge
Copy link
Owner

Closes #231

This PR also attempts to update various tidyverse functions to recent versions.

@juliasilge
Copy link
Owner Author

@MichaelChirico do you know of any alt text issues that aren't addressed here? No worries if you don't have specific feedback.

@MichaelChirico
Copy link
Contributor

hmm I'll see if I can run our tool here somehow.

it's usually run on the unzipped CRAN tarball which puts the HTML vignettes in inst/doc, it may be easier to grep for any <img> tags there instead

@juliasilge
Copy link
Owner Author

juliasilge commented Mar 23, 2023

@MichaelChirico Feel free to open another issue if you see further problems!

@juliasilge juliasilge merged commit 8707ad0 into main Mar 23, 2023
@juliasilge juliasilge deleted the alt-text branch March 23, 2023 13:29
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility issue] Vignettes lacks alt= in plots
2 participants